[PATCH] Implement shift ops for Mips fast-isel

[Eric Christopher]

Hi Reed,

Inline comments. Also, everything Daniel said.

-eric


================
Comment at: lib/Target/Mips/MipsFastISel.cpp:1297
@@ +1296,3 @@
+  switch (DVT.SimpleTy) {
+  default:
+    // Trunc i64 to i32 is handled by the target-independent fast-isel.
----------------
I'd add this assert:

assert((DVT.SimpleTy != MVT::i32 && DVT.SimpleTy != MVT::i64) && "i64 and i32 should have been handled by target-independent fast-isel!");

================
Comment at: lib/Target/Mips/MipsFastISel.cpp:1448
@@ +1447,3 @@
+    default:
+      llvm_unreachable("Unexpected instruction.");
+    case Instruction::Shl:
----------------
Is this an actual error or what?

================
Comment at: lib/Target/Mips/MipsFastISel.cpp:1473
@@ +1472,3 @@
+  default:
+    llvm_unreachable("Unexpected instruction.");
+  case Instruction::Shl:
----------------
Is this an actual error or what?

http://reviews.llvm.org/D6726

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/