[PATCH] Add Darwin 13.4 x86_64 builder

[Siva Chandra]

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:386
@@ -370,1 +385,3 @@
+                                    WithProperties('OBJROOT=' + OBJROOT)],
+                           haltOnFailure=False,
                            workdir=lldb_srcdir))
----------------
haltOnFailure=True ?

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:409
@@ +408,3 @@
+
+    testCmd=WithProperties("export DYLD_FRAMEWORK_PATH=%(lldb_bindir)s && ./dosep.py --options '-m --executable %(lldb_bindir)s/lldb --framework %(lldb_bindir)s/LLDB.framework -A x86_64 -C clang -s ../DerivedData/lldb-test-results'")
+    f.addStep(LitTestCommand(name='lldb-test',
----------------
Isn't there an equivalent of nina/make check-lldb for Darwin?

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:413
@@ -393,1 +412,3 @@
+                             haltOnFailure=True,
+                             workdir='%s/test' % lldb_srcdir))
 
----------------
Instead of a single string setting the environment and invoking dosep, you can specify the enivorment in kwargs to LiTestCommand. So, you can remove testCmd and have something like this:

    f.addStep(LitTestCommand(name='lldb-test',
                             command=[<the list with dosep command args>],
                             haltOnFailure=True,
                             workdir='%s/test' % lldb_srcdir,
                             env={'DYLD_FRAMEWORK_PATH' : WithProperties('%(lldb_bindir)s')}))

Please do test that this works.

http://reviews.llvm.org/D7896

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/