[llvm] r230675 - InstrProf: Rename ObjectFileCoverageMappingReader to BinaryCoverageReader

Justin Bogner mail at justinbogner.com
Thu Feb 26 12:06:25 PST 2015


Author: bogner
Date: Thu Feb 26 14:06:24 2015
New Revision: 230675

URL: http://llvm.org/viewvc/llvm-project?rev=230675&view=rev
Log:
InstrProf: Rename ObjectFileCoverageMappingReader to BinaryCoverageReader

The current name is long and confusing. A shorter one is both easier
to understand and easier to work with.

Modified:
    llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h
    llvm/trunk/lib/ProfileData/CoverageMapping.cpp
    llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp

Modified: llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h?rev=230675&r1=230674&r2=230675&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h (original)
+++ llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h Thu Feb 26 14:06:24 2015
@@ -142,7 +142,7 @@ private:
 
 /// \brief Reader for the coverage mapping data that is emitted by the
 /// frontend and stored in an object file.
-class ObjectFileCoverageMappingReader : public CoverageMappingReader {
+class BinaryCoverageReader : public CoverageMappingReader {
 public:
   struct ProfileMappingRecord {
     CoverageMappingVersion Version;
@@ -170,10 +170,8 @@ private:
   std::vector<CounterExpression> Expressions;
   std::vector<CounterMappingRegion> MappingRegions;
 
-  ObjectFileCoverageMappingReader(const ObjectFileCoverageMappingReader &)
-      = delete;
-  ObjectFileCoverageMappingReader &
-  operator=(const ObjectFileCoverageMappingReader &) = delete;
+  BinaryCoverageReader(const BinaryCoverageReader &) = delete;
+  BinaryCoverageReader &operator=(const BinaryCoverageReader &) = delete;
 
   /// \brief Set the current error_code and return same.
   std::error_code error(std::error_code EC) {
@@ -185,7 +183,7 @@ private:
   std::error_code success() { return error(instrprof_error::success); }
 
 public:
-  ObjectFileCoverageMappingReader(std::unique_ptr<MemoryBuffer> &ObjectBuffer);
+  BinaryCoverageReader(std::unique_ptr<MemoryBuffer> &ObjectBuffer);
 
   std::error_code readHeader();
   std::error_code readNextRecord(CoverageMappingRecord &Record) override;

Modified: llvm/trunk/lib/ProfileData/CoverageMapping.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/CoverageMapping.cpp?rev=230675&r1=230674&r2=230675&view=diff
==============================================================================
--- llvm/trunk/lib/ProfileData/CoverageMapping.cpp (original)
+++ llvm/trunk/lib/ProfileData/CoverageMapping.cpp Thu Feb 26 14:06:24 2015
@@ -221,7 +221,7 @@ CoverageMapping::load(StringRef ObjectFi
   auto CounterMappingBuff = MemoryBuffer::getFileOrSTDIN(ObjectFilename);
   if (auto EC = CounterMappingBuff.getError())
     return EC;
-  ObjectFileCoverageMappingReader CoverageReader(CounterMappingBuff.get());
+  BinaryCoverageReader CoverageReader(CounterMappingBuff.get());
   if (auto EC = CoverageReader.readHeader())
     return EC;
   auto ProfileReaderOrErr = IndexedInstrProfReader::create(ProfileFilename);

Modified: llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp?rev=230675&r1=230674&r2=230675&view=diff
==============================================================================
--- llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp (original)
+++ llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp Thu Feb 26 14:06:24 2015
@@ -334,7 +334,7 @@ struct SectionData {
 template <typename T>
 std::error_code readCoverageMappingData(
     SectionData &ProfileNames, StringRef Data,
-    std::vector<ObjectFileCoverageMappingReader::ProfileMappingRecord> &Records,
+    std::vector<BinaryCoverageReader::ProfileMappingRecord> &Records,
     std::vector<StringRef> &Filenames) {
   llvm::DenseSet<T> UniqueFunctionMappingData;
 
@@ -400,7 +400,7 @@ std::error_code readCoverageMappingData(
               ProfileNames.get(MappingRecord.FunctionNamePtr,
                                MappingRecord.FunctionNameSize, FunctionName))
         return Err;
-      Records.push_back(ObjectFileCoverageMappingReader::ProfileMappingRecord(
+      Records.push_back(BinaryCoverageReader::ProfileMappingRecord(
           Version, FunctionName, MappingRecord.FunctionHash, Mapping,
           FilenamesBegin, Filenames.size() - FilenamesBegin));
     }
@@ -438,7 +438,7 @@ static std::error_code decodeTestingForm
   return instrprof_error::success;
 }
 
-ObjectFileCoverageMappingReader::ObjectFileCoverageMappingReader(
+BinaryCoverageReader::BinaryCoverageReader(
     std::unique_ptr<MemoryBuffer> &ObjectBuffer)
     : CurrentRecord(0) {
   if (ObjectBuffer->getBuffer().startswith(TestingFormatMagic)) {
@@ -466,7 +466,7 @@ ObjectFileCoverageMappingReader::ObjectF
                                       std::move(ObjectBuffer));
 }
 
-std::error_code ObjectFileCoverageMappingReader::readHeader() {
+std::error_code BinaryCoverageReader::readHeader() {
   const ObjectFile *OF = Object.getBinary();
   if (!OF)
     return getError();
@@ -515,7 +515,7 @@ std::error_code ObjectFileCoverageMappin
 }
 
 std::error_code
-ObjectFileCoverageMappingReader::readNextRecord(CoverageMappingRecord &Record) {
+BinaryCoverageReader::readNextRecord(CoverageMappingRecord &Record) {
   if (CurrentRecord >= MappingRecords.size())
     return error(instrprof_error::eof);
 





More information about the llvm-commits mailing list