[PATCH] [lld] [LinkerScript] Implement semantics for simple sections mappings

Shankar Kalpathi Easwaran shankarke at gmail.com
Thu Feb 26 11:54:18 PST 2015


Cool!

Few comments :-

a) We should assign rule id's to Sections, and not to DefinedAtoms.

- The ruleid could be assigned when parsing linker scripts, and you attach a rule id to it.
- DefinedAtoms should not have this extra member ruleid.
- So when the AtomSection is queried for the output section from the LinkerScript datastructure, it would return a tuple that contains the (order_of_outputsection, ruleid).

b) All the linker script matching would be not be done in the DefaultLayout class. ScriptLayout was essentially designed to take advantage of linker scripts.


http://reviews.llvm.org/D7915

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list