[PATCH] FileCheck: Add CHECK-SAME

Robinson, Paul Paul_Robinson at playstation.sony.com
Wed Feb 25 20:30:24 PST 2015


LGTM.  Not that I'm any kind of code owner but it looks straightforward
and the test case is way clearer now.
--paulr

> -----Original Message-----
> From: Duncan P. N. Exon Smith [mailto:dexonsmith at apple.com]
> Sent: Wednesday, February 25, 2015 5:32 PM
> To: Robinson, Paul
> Cc: Commit Messages and Patches for LLVM
> Subject: Re: [PATCH] FileCheck: Add CHECK-SAME
> 
> 
> > On 2015 Feb 25, at 17:14, Robinson, Paul
> <Paul_Robinson at playstation.sony.com> wrote:
> >
> > Ooooh nice.
> >
> > I would combine same-match.txt and same-no-match.txt (which have the
> same sample input) into one test file, and use --check-prefix to
> distinguish one of the cases. Which concurrently proves that –SAME works
> with alternate prefixes, not that there's much doubt.
> > --paulr
> 
> Good idea.  I merged all the testcases into one file, and it
> seems a little more clear to me.
> 
> Fresh patch attached.





More information about the llvm-commits mailing list