[PATCH] Anonymous namespaces are missing import DW_TAG_imported_module.

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Feb 25 19:34:39 PST 2015


> On 2015 Feb 25, at 19:19, Katya Romanova <Katya_Romanova at playstation.sony.com> wrote:
> 
> I have already created a review for this bug a few hours ago, but it didn't reach the full audience. I didn't add llvm--dev at first when I created the review. Apparently, adding it later doesn't have any effect and the review wasn't sent out to the mailing list. I abandoned the old review and created this one.

Sadly, there's still no patch on the list.  I'm not sure what you
need to do to make phabricator post it for you.

Feel free to go "low-tech" and just attach the patch to an email
(maybe in reply to this one?).

(BTW, Phabricator isn't required for reviews; it's just a tool
that some find useful (IIUC because downloading/applying/editing
patches is difficult in some environments?).)

> Here are a couple of comments that were added to the old review by the people who were specified as the reviewers:
> 
> from David Blaikie:
> 
>>> I'm not sure if this is really a bug in the debug info - seems like it might be reasonably treated as a bug in the debugger?
> 
>> 
> 
> 
> from Paul Robinson:
> 
>>> Our debugger guys get pretty pedantic about interpreting the DWARF spec. I know GDB will auto-import info from an anonymous namespace, but:
> 
>> 
> 
>>> 
> 
>> 
> 
>>>  the size cost here is really minimal (what, 5 or 6 bytes per anonymous namespace scope);
> 
>> 
> 
>>>  they claimed that deciding whether to skip the namespace based on the name would be a problem for them;
> 
>> 
> 
>>>  the compiler implementation is obviously trivial;
> 
>> 
> 
> 
> 
> 
>>> so I didn't really feel motivated to argue the point.
> 
>> 
> 
> 
> 
> http://reviews.llvm.org/D7895
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list