[llvm] r230585 - Remove a FIXME.

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Feb 25 17:38:21 PST 2015


> On 2015 Feb 25, at 16:00, Eric Christopher <echristo at gmail.com> wrote:
> 
> Author: echristo
> Date: Wed Feb 25 18:00:35 2015
> New Revision: 230585
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=230585&view=rev
> Log:
> Remove a FIXME.
> 
> Explanation: This function is in TargetLowering because it uses
> RegClassForVT which would need to be moved to TargetRegisterInfo
> and would necessitate moving isTypeLegal over as well - a massive
> change that would just require TargetLowering having a TargetRegisterInfo
> class member that it would use.

Should this be in a doxygen comment in the header?

> 
> Modified:
>    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> 
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=230585&r1=230584&r2=230585&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Feb 25 18:00:35 2015
> @@ -1930,7 +1930,6 @@ getPICJumpTableRelocBaseExpr(const Machi
>   return MCSymbolRefExpr::Create(MF->getPICBaseSymbol(), Ctx);
> }
> 
> -// FIXME: Why this routine is here? Move to RegInfo!
> std::pair<const TargetRegisterClass *, uint8_t>
> X86TargetLowering::findRepresentativeClass(const TargetRegisterInfo *TRI,
>                                            MVT VT) const {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list