[PATCH] Preliminary support for dynamically loadable coff objects

Zachary Turner zturner at google.com
Wed Feb 25 15:38:38 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/ExecutionEngine/RuntimeDyld/CMakeLists.txt:8
@@ -6,2 +7,3 @@
   RuntimeDyldMachO.cpp
+  Targets/RuntimeDyldCOFFX86_64.cpp
   )
----------------
Minor CMake style nit.  The relationship between this folder and Targets is a little awkward (not because of your doing, seems historical).  In any case, adding a file from a subfolder into this library can be strange to someone using an IDE because they will see RuntimeDyldCOFFX86_64.cpp in the same file list as the rest, even though it's in a different location on disk.  

It might be a little better if "Targets" showed up as a folder in the IDE, with RuntimeDyldCOFFx86_64.cpp showing up under that folder.  An example of the CMake needed to do this is in \lib\DebugInfo\PDB\CMakeLists.txt.  It's only a couple of boiler plate lines.

http://reviews.llvm.org/D7793

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list