[llvm] r230563 - InstrProf: Remove dead code in CoverageMappingReader

Justin Bogner mail at justinbogner.com
Wed Feb 25 14:44:51 PST 2015


Author: bogner
Date: Wed Feb 25 16:44:50 2015
New Revision: 230563

URL: http://llvm.org/viewvc/llvm-project?rev=230563&view=rev
Log:
InstrProf: Remove dead code in CoverageMappingReader

Remove a default argument that's never passed and a constructor that's
never called.

Modified:
    llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h
    llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp

Modified: llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h?rev=230563&r1=230562&r2=230563&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h (original)
+++ llvm/trunk/include/llvm/ProfileData/CoverageMappingReader.h Wed Feb 25 16:44:50 2015
@@ -185,10 +185,7 @@ private:
   std::error_code success() { return error(instrprof_error::success); }
 
 public:
-  ObjectFileCoverageMappingReader(StringRef FileName);
-  ObjectFileCoverageMappingReader(
-      std::unique_ptr<MemoryBuffer> &ObjectBuffer,
-      sys::fs::file_magic Type = sys::fs::file_magic::unknown);
+  ObjectFileCoverageMappingReader(std::unique_ptr<MemoryBuffer> &ObjectBuffer);
 
   std::error_code readHeader();
   std::error_code readNextRecord(CoverageMappingRecord &Record) override;

Modified: llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp?rev=230563&r1=230562&r2=230563&view=diff
==============================================================================
--- llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp (original)
+++ llvm/trunk/lib/ProfileData/CoverageMappingReader.cpp Wed Feb 25 16:44:50 2015
@@ -286,16 +286,6 @@ std::error_code RawCoverageMappingReader
   return success();
 }
 
-ObjectFileCoverageMappingReader::ObjectFileCoverageMappingReader(
-    StringRef FileName)
-    : CurrentRecord(0) {
-  auto File = llvm::object::ObjectFile::createObjectFile(FileName);
-  if (!File)
-    error(File.getError());
-  else
-    Object = std::move(File.get());
-}
-
 namespace {
 /// \brief The coverage mapping data for a single function.
 /// It points to the function's name.
@@ -449,7 +439,7 @@ static std::error_code decodeTestingForm
 }
 
 ObjectFileCoverageMappingReader::ObjectFileCoverageMappingReader(
-    std::unique_ptr<MemoryBuffer> &ObjectBuffer, sys::fs::file_magic Type)
+    std::unique_ptr<MemoryBuffer> &ObjectBuffer)
     : CurrentRecord(0) {
   if (ObjectBuffer->getBuffer().startswith(TestingFormatMagic)) {
     // This is a special format used for testing.
@@ -467,8 +457,8 @@ ObjectFileCoverageMappingReader::ObjectF
     return;
   }
 
-  auto File = object::ObjectFile::createObjectFile(
-      ObjectBuffer->getMemBufferRef(), Type);
+  auto File =
+      object::ObjectFile::createObjectFile(ObjectBuffer->getMemBufferRef());
   if (!File)
     error(File.getError());
   else





More information about the llvm-commits mailing list