[PATCH] This patch introduces MemorySSA, a virtual SSA form for memory.Details on what it looks like are in MemorySSA.h

[James Molloy]

Hi Daniel,

One inline comment about the design. Sorry for the naiveity.

Cheers,

James


================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:150
@@ +149,3 @@
+// All defs also have a use
+class MemoryDef : public MemoryUse {
+public:
----------------
I don't understand this: Firstly, why must all defs have a use? We can store without loading the resulting value back.

Secondly, you've used inheritance which is an "is-a" relationship. Is there something fundamental I'm missing here?

http://reviews.llvm.org/D7864

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/