[llvm] r225562 - Use the DiagnosticHandler to print diagnostics when reading bitcode.

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Feb 25 10:32:33 PST 2015


> On 2015 Feb 25, at 10:22, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> 
>> I committed the llvm-dis patch in r230416, so you just need
>> to do the gold-plugin.
> 
> I noticed that I couldn't get gold to crash. The Reason is that
> UpgradeDebugInfo is called from MaterializeModule, which the plugin
> avoids calling.
> 
> There is probably too much going on right now with regards to debug
> info format to change it, but it is something we will need to change
> in the future.

Any non-trivial output from `clang-3.5 -gline-tables-only -flto` should
cause ToT gold-plugin to crash if this stripping isn't in place, but
I'm not sure who uses gold-plugin in production (or what the
assumptions are around it) so maybe it's not too important right now.





More information about the llvm-commits mailing list