[PATCH] DAGCombiner: Continue combining if FoldConstantArithmetic() fails.

Matthias Braun matze at braunis.de
Wed Feb 25 10:11:56 PST 2015


I can't commit the first part without the second because it leads to the DAGCombiner folding many opaque constants back to normal constants breaking lit tests and generally defeating the intention of ContantHoisting pass.

- Matthias

> On Feb 24, 2015, at 11:25 AM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
> 
> I think there are two parts here:
> 
> - checking the return value of FoldConstantArithmetic: that LGTM, though tests would of course be appreciated, if possible.
> - disabling some optimizations on Opaque constants: that, I'll let Juergen comment on.  I'm opposed to it because of the brittleness, but pragmatically (and there's precedent) that's a reasonable solution.
> 
> For your assert failure, I'm fine with just fixing that for now (that would be r230355, correct?).
> 
> -Ahmed
> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D6946
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the llvm-commits mailing list