[compiler-rt] r230256 - [asan] when registering globals, use the same unwinder as we use for malloc, instead of the one used for FATAL crash (which may be too slow)

Kostya Serebryany kcc at google.com
Wed Feb 25 08:25:59 PST 2015


And we can disable the test on ARM for now to make the bot green

On Wed, Feb 25, 2015 at 8:17 AM, Kostya Serebryany <kcc at google.com> wrote:

> Can we investigate offline and fix, instead of reverting?
> Can you run the test manually and show what does it print?
>
> On Wed, Feb 25, 2015 at 5:05 AM, Renato Golin <renato.golin at linaro.org>
> wrote:
>
>> Hi Kostya,
>>
>> The fix didn't work, shall we revert the patch and investigate offline?
>>
>> cheers,
>> --renato
>>
>> On 24 February 2015 at 11:38, Renato Golin <renato.golin at linaro.org>
>> wrote:
>> > On 23 February 2015 at 20:40, Kostya Serebryany <kcc at google.com> wrote:
>> >> Author: kcc
>> >> Date: Mon Feb 23 14:40:53 2015
>> >> New Revision: 230256
>> >>
>> >> URL: http://llvm.org/viewvc/llvm-project?rev=230256&view=rev
>> >> Log:
>> >> [asan] when registering globals, use the same unwinder as we use for
>> malloc, instead of the one used for FATAL crash (which may be too slow)
>> >
>> > Hi Kostya,
>> >
>> > This patch broke this test:
>> >
>> >
>> http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/3888/steps/ninja%20check%201/logs/AddressSanitizer-arm-linux%3A%3Aodr-violation.cc
>> >
>> > I reverted your patch locally and the test then passes. Can you have a
>> > look, please?
>> >
>> > cheers,
>> > -renato
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150225/3aa54bea/attachment.html>


More information about the llvm-commits mailing list