[llvm] r230229 - [X86] Add specific mtriple in order to appease builbots

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Wed Feb 25 04:52:25 PST 2015


Cool, I did not see r230404 till now.

Thanks Eric :-)


On Wed, Feb 25, 2015 at 1:27 AM, Eric Christopher <echristo at gmail.com> wrote:
> Which is what I did. :)
>
> -eric
>
>
> On Tue, Feb 24, 2015, 8:20 PM Bruno Cardoso Lopes <bruno.cardoso at gmail.com>
> wrote:
>>
>> I'm not sure, -mtriple=x86_64-win32-pc has other different output due
>> to its calling convention (input registers for instance), so binding
>> to x86_64-darwin seemed a less intrusive change. This will likely fail
>> on windows hosts but I guess that could be fixed by using regex on the
>> registers.
>>
>> On Tue, Feb 24, 2015 at 8:45 PM, Eric Christopher <echristo at gmail.com>
>> wrote:
>> > That one wouldn't quite work, but I committed one in r230400 that does.
>> >
>> > -eric
>> >
>> > On Tue Feb 24 2015 at 1:46:39 PM Eric Christopher <echristo at gmail.com>
>> > wrote:
>> >>
>> >> The difference here is just the number of # in comments. The attached
>> >> patch works for it (and means there's no need to make this change as it
>> >> shouldn't be triple specific).
>> >>
>> >> Honestly it's probably a bug that darwin emits two of them :)
>> >>
>> >> -eric
>> >>
>> >>
>> >> On Mon Feb 23 2015 at 7:38:06 AM Bruno Cardoso Lopes
>> >> <bruno.cardoso at gmail.com> wrote:
>> >>>
>> >>> Author: bruno
>> >>> Date: Mon Feb 23 09:33:40 2015
>> >>> New Revision: 230229
>> >>>
>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=230229&view=rev
>> >>> Log:
>> >>> [X86] Add specific mtriple in order to appease builbots
>> >>>
>> >>> Modified:
>> >>>     llvm/trunk/test/CodeGen/X86/mmx-fold-load.ll
>> >>>
>> >>> Modified: llvm/trunk/test/CodeGen/X86/mmx-fold-load.ll
>> >>> URL:
>> >>>
>> >>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/mmx-fold-load.ll?rev=230229&r1=230228&r2=230229&view=diff
>> >>>
>> >>>
>> >>> ==============================================================================
>> >>> --- llvm/trunk/test/CodeGen/X86/mmx-fold-load.ll (original)
>> >>> +++ llvm/trunk/test/CodeGen/X86/mmx-fold-load.ll Mon Feb 23 09:33:40
>> >>> 2015
>> >>> @@ -1,4 +1,4 @@
>> >>> -; RUN: llc < %s -march=x86-64 -mattr=+mmx,+sse2 | FileCheck %s
>> >>> +; RUN: llc < %s -mtriple=x86_64-darwin -mattr=+mmx,+sse2 | FileCheck
>> >>> %s
>> >>>
>> >>>  define i64 @t0(<1 x i64>* %a, i32* %b) {
>> >>>  ; CHECK-LABEL: t0:
>> >>>
>> >>>
>> >>> _______________________________________________
>> >>> llvm-commits mailing list
>> >>> llvm-commits at cs.uiuc.edu
>> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>>
>> --
>> Bruno Cardoso Lopes
>> http://www.brunocardoso.cc



-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc



More information about the llvm-commits mailing list