[PATCH] asan: do not instrument direct inbounds accesses to stack variables

Kostya Serebryany kcc at google.com
Tue Feb 24 18:16:19 PST 2015


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:189
@@ -184,1 +188,3 @@
+       cl::desc("Don't instrument scalar stack variables"), cl::Hidden,
+       cl::init(true));
 
----------------
zaks.anna wrote:
> This makes me nervous. I don't think ObjectSizeOffsetEvaluator is used much. This should probably go through more testing, though I am not sure how to catch issues here since we are removing checking.
ouch. Indeed, don't make it true by default for now. 
Unfortunately, I don't know any good way to test complex optimizations that eliminate checks,
and so I don't know what it will take us to enable this by default. 
But at least having this code in trunk will simplify the experiments.

http://reviews.llvm.org/D7583

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list