[llvm] r230416 - llvm-dis: Stop crashing when dropping debug info

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Feb 24 17:35:40 PST 2015


> On 2015-Feb-24, at 17:10, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> Author: dexonsmith
> Date: Tue Feb 24 19:10:03 2015
> New Revision: 230416
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=230416&view=rev
> Log:
> llvm-dis: Stop crashing when dropping debug info
> 
> Since r199356, we've printed a warning when dropping debug info.
> r225562 started crashing on that, since it registered a diagnostic
> handler that only expected errors.  This fixes the handler to expect
> other severities.  As a side effect, it now prints "error: " at the
> start of error messages, similar to `llvm-as`.
> 
> There was a testcase for r199356, but it only really checked the
> assembler.  Move `test/Bitcode/drop-debug-info.ll` to `test/Assembler`,
> and introduce `test/Bitcode/drop-debug-info.3.5.ll` (and companion
> `.bc`) to test the bitcode reader.
> 
> Note: tools/gold/gold-plugin.cpp has an equivalent bug, but I'm not sure
> what the best fix is there.

Commit message correct up to here.

> I'll file a PR.

Not actually true.  Rafael is just going to fix this.



More information about the llvm-commits mailing list