[PATCH] [compiler-rt] Symbolizer refactoring: Move SymbolizerProcess interface to header

Alexey Samsonov vonosmas at gmail.com
Tue Feb 24 16:51:12 PST 2015


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer.h:156
@@ +155,3 @@
+  explicit SymbolizerProcess(const char *path);
+  char *SendCommand(bool is_data, const char *module_name, uptr module_offset);
+
----------------
Please add `override` here.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer.h:158
@@ +157,3 @@
+
+ protected:
+  bool Restart();
----------------
Why did you change `private:` to `protected:` ?

http://reviews.llvm.org/D7868

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list