[PATCH] DAGCombiner: Continue combining if FoldConstantArithmetic() fails.

[Matthias Braun]

That would obviously involve changing all targets to recognize that new node type, in all sorts of different addressing modes. I also don't know whether all of this was already discussed when OpaqueConstants were introduced. Anyway I just wanted to fix a few bugs here and not rewrite all this stuff, so this patch won't get a LGTM unless it's a rewrite of the whole OpaqueConstants concepts?

- Matthias

> On Feb 24, 2015, at 10:33 AM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
> 
> Fair enough, reordering the optimizations isn't a solution.  Looking through old commits, I see there are a few that do exactly this: add isOpaque checks around DAG combines.
> Having a separate node type for opaque constants does sound less brittle;  any idea of what would be involved?
> 
> -Ahmed
> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D6946
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits