[PATCH] Add ScalarEvolution bounds to non-affine access functions
Sebastian Pop
sebpop at gmail.com
Tue Feb 24 06:22:39 PST 2015
LGTM
================
Comment at: lib/Analysis/ScopInfo.cpp:307
@@ +306,3 @@
+ int dim,
+ enum isl_dim_type type) {
+ isl_val *V;
----------------
Please use capital letters for variable names: Dim, Type, Ctx.
================
Comment at: lib/Analysis/ScopInfo.cpp:320
@@ +319,3 @@
+ return isl_set_union(SLB, SUB);
+ else
+ return isl_set_intersect(SLB, SUB);
----------------
No need of "else" after return.
http://reviews.llvm.org/D7839
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list