[PATCH] Remove redundent register mov by improving TwoAddressInstructionPass

Chandler Carruth chandlerc at gmail.com
Mon Feb 23 18:46:28 PST 2015


No real comments on the code, Quentin knows it much better than I do. =]


REPOSITORY
  rL LLVM

================
Comment at: test/CodeGen/X86/twoaddr-coalesce-3.ll:7
@@ +6,3 @@
+; Function Attrs: nounwind uwtable
+define void @foo() #0 {
+entry:
----------------
qcolombet wrote:
> Remove metadata and explain what this function is testing, so that future updates would be easier.
In addition, if there is a way to fold this into an existing test, that would be much better. This is usually possible due to using FileCheck, and CHECK-LABEL bracketed assertions.

http://reviews.llvm.org/D7806

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list