[PATCH] [DagCombiner] Generalized BuildVector Vector Concatenation

Simon Pilgrim llvm-dev at redking.me.uk
Mon Feb 23 14:23:13 PST 2015


> I think you are right and the patch shouldn't have used 'getScalarType()'.

>  We cannot assume that 'VT.getScalarType()' always returns a legal type for the target.

>  Variable SVT should have been initialized to something like: 'N0.getOperand(0)->getValueType(0);', where N0 is the first operand to the concat_vector.


Hi Guys - you're absolutely right - we need to use the build vector input operand value type, not the build vector scalar type. I will get a fix in shortly.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7816

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list