[lld] r230191 - [ELF] Add symbol to ELFReference.

Shankar Easwaran shankare at codeaurora.org
Mon Feb 23 13:40:18 PST 2015


Since its the same opinion raised by you/Rui, I can change the code to 
use a map. Will send it for review, soon.

Shankar Easwaran

On 2/23/2015 3:22 PM, Simon Atanasyan wrote:
> As far as I can see we need to keep links to symbols just while we
> create references. IMHO it is a bit redundant to keep these links
> infinitely. So maybe it is better to maintain a map reference=>symbol
> and use this map in the ELFFile::updateReferences() method.
>
> On Mon, Feb 23, 2015 at 11:27 PM, Shankar Easwaran
> <shankare at codeaurora.org> wrote:
>> You can see the function, ELFFile::updateReferences.
>>
>> On 2/23/2015 2:24 PM, Simon Atanasyan wrote:
>>> Hi Shankar,
>>>
>>> Where can I see how we the use new `ELFReference::symbol()` method?
>>>
>>> On Mon, Feb 23, 2015 at 2:46 AM, Shankar Easwaran
>>> <shankare at codeaurora.org> wrote:
>>>> Author: shankare
>>>> Date: Sun Feb 22 17:46:21 2015
>>>> New Revision: 230191
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=230191&view=rev
>>>> Log:
>>>> [ELF] Add symbol to ELFReference.
>>>>
>>>> Relocation handling need more information about the Symbol that we are
>>>> creating
>>>> references for.
>>>>
>>>> No change in functionality.
>>>>
>>>> Modified:
>>>>       lld/trunk/lib/ReaderWriter/ELF/Atoms.h
>>>>       lld/trunk/lib/ReaderWriter/ELF/ELFFile.h
>>>>       lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFFile.h


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list