[PATCH] LowerBitSets: Introduce global layout builder.

[Peter Collingbourne]

================
Comment at: include/llvm/Transforms/IPO/LowerBitSets.h:120
@@ +119,3 @@
+  /// The computed layout. Clients should use a nested pair of for loops to
+  /// access the object indices.
+  std::vector<std::vector<uint64_t>> Fragments;
----------------
jfb wrote:
> I'm not sure I understand how "Clients should use a nested pair of for loops to access the object indices." is helpful. Are you trying to illustrate the order of indices?
Yes. I rewrote this to hopefully be more useful.

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:534
@@ +533,3 @@
+    if (BitSetNM) {
+      for (MDNode *Op : BitSetNM->operands()) {
+        if (!Op->getOperand(1))
----------------
jfb wrote:
> Could you clarify below what operands 0 and 1 are? It's not obvious from the surrounding code.
Done

http://reviews.llvm.org/D7796

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/