[llvm] r230252 - Attempting to fix WinEHCatchDirector destructor related build failures.

Kaylor, Andrew andrew.kaylor at intel.com
Mon Feb 23 12:39:25 PST 2015


It was just a guess.  I’m not seeing the build failures locally that this was trying to fix.

From: David Blaikie [mailto:dblaikie at gmail.com]
Sent: Monday, February 23, 2015 12:38 PM
To: Kaylor, Andrew
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r230252 - Attempting to fix WinEHCatchDirector destructor related build failures.



On Mon, Feb 23, 2015 at 12:19 PM, Andrew Kaylor <andrew.kaylor at intel.com<mailto:andrew.kaylor at intel.com>> wrote:
Author: akaylor
Date: Mon Feb 23 14:19:15 2015
New Revision: 230252

URL: http://llvm.org/viewvc/llvm-project?rev=230252&view=rev
Log:
Attempting to fix WinEHCatchDirector destructor related build failures.


Modified:
    llvm/trunk/lib/CodeGen/WinEHPrepare.cpp

Modified: llvm/trunk/lib/CodeGen/WinEHPrepare.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/WinEHPrepare.cpp?rev=230252&r1=230251&r2=230252&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/WinEHPrepare.cpp (original)
+++ llvm/trunk/lib/CodeGen/WinEHPrepare.cpp Mon Feb 23 14:19:15 2015
@@ -96,6 +96,7 @@ public:
         Materializer(CatchFn, VarInfo),
         SelectorIDType(Type::getInt32Ty(LPI->getContext())),
         Int8PtrType(Type::getInt8PtrTy(LPI->getContext())) {}
+  virtual ~WinEHCatchDirector() = default;

Why would this do anything if the base class already has a virtual dtor? (& if it stays this way, it should be marked override, not virtual, since it's already virtual in the base class -Winconsistent-missing-override will fire on this code as-is, I think)


   CloningAction handleInstruction(ValueToValueMapTy &VMap,
                                   const Instruction *Inst,


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150223/ac43dac0/attachment.html>


More information about the llvm-commits mailing list