[PATCH] [IC] Turn non-null MD on pointer loads to range MD on integer loads.

Philip Reames listmail at philipreames.com
Mon Feb 23 11:36:58 PST 2015


LGTM, though please hold off on the submit until Chandler has a chance to glance over it.  He knows this code better than I do.


================
Comment at: lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:346
@@ +345,3 @@
+                             MDBuilder(NewLoad->getContext())
+                               .createRange(APInt(ITy->getBitWidth(), 1),
+                                            ITy->getMask()));
----------------
I'd have a mild preference that the builder be pulled out into it's own statement, but we're into nits at this point.  Feel free to ignore.

http://reviews.llvm.org/D7621

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list