[PATCH] [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend

Vladimir Medic Vladimir.Medic at imgtec.com
Mon Feb 23 09:31:13 PST 2015


Could we do that in a separate patch? I would prefer to submit this one without initialization with old fixme comment and commit it in order to get the abi working. In the next patch we can initialize MCtargetOptions from AssemblerInvocation(adding the fields we need in the structure).
________________________________
From: Eric Christopher [echristo at gmail.com]
Sent: Friday, February 20, 2015 6:54 PM
To: reviews+D7747+public+d517a63d5c1d02a4 at reviews.llvm.org; Vladimir Medic; Daniel Sanders
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend



On Fri Feb 20 2015 at 6:10:02 AM Vladimir Medic <Vladimir.Medic at imgtec.com<mailto:Vladimir.Medic at imgtec.com>> wrote:
================
Comment at: tools/driver/cc1as_main.cpp:358
@@ -357,2 +357,3 @@
       TheTarget->createMCSubtargetInfo(Opts.Triple, Opts.CPU, FS));
+  MCTargetOptions Options = InitMCTargetOptionsFromFlags();

----------------
echristo wrote:
> I'd prefer not to do this, clang already has its own option handling. Ideas on how to avoid this?
Not right now, at least not a simple one. The FIXME comment that was removed said:"init MCTargetOptions from sanitizer flags here." So we should probably need to map clang options to MCTargetOptions.


I think we should do that.

In particular here you should map the -mabi option.

Thanks!

-eric

http://reviews.llvm.org/D7747

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150223/79e539e2/attachment.html>


More information about the llvm-commits mailing list