[PATCH] [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple.

Daniel Sanders daniel.sanders at imgtec.com
Mon Feb 23 09:22:30 PST 2015


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsAsmBackend.h:33
@@ -32,3 +32,3 @@
   bool Is64Bit;  // 32 or 64 bit words
-
+  bool IsN64;    // Is ABI n64
 public:
----------------
echristo wrote:
> You could probably store just the ABI here and unify the previous 3 class variables with just the triple rather than OSType.
I don't think we should unify those variables. The triple is meaningless except in so far as it implies some default values.

For example, mips-linux-gnu in conjunction with the -mips64r2 option is equivalent to mips64-linux-gnu. Conversely mips64-linux-gnu and -mips32r2 is equivalent to mips-linux-gnu. I think it's better to keep the values separate and stick to initializing them from the options and (when lacking explicit options) the triple.

IsLittle can probably be derived from the triple but only because we have some dubious code to change the triple given to the backend when -EL and -EB are given to clang.

http://reviews.llvm.org/D6476

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list