[PATCH] Beginning of alloca implementation for Mips fast-isel

[Daniel Sanders]

LGTM


================
Comment at: lib/Target/Mips/MipsFastISel.cpp:1-3
@@ -1,4 +1,4 @@
 //===-- MipsastISel.cpp - Mips FastISel implementation
 //---------------------===//
 
 #include "MipsCCState.h"
----------------
Phabricator won't let me delete this inline comment for some reason but it will let me edit it.

I was going to ask why this change was reverted but I've gone back through the comments and answered my own question (it's being committed separately)

================
Comment at: lib/Target/Mips/MipsFastISel.cpp:1354
@@ -1245,1 +1353,3 @@
 
+void MipsFastISel::simplifyAddress(Address &Addr) {
+  if (!isInt<16>(Addr.getOffset())) {
----------------
I'm happy with this solution to the "it's not obvious the argument is modified" issue since the function name now implies the modification.

================
Comment at: test/CodeGen/Mips/Fast-ISel/overflt.ll:56-61
@@ +55,8 @@
+;float result;
+
+
+;void foo() {
+;  y[64000] = 5.5;
+;}
+
+;void goo() {
----------------
Nit: The blank lines should probably be ';' since this is one big block comment

http://reviews.llvm.org/D6426

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/