Use common parse routine to read alignment values from bitcode.

[JF Bastien]

Committed as r230180.

On Fri, Feb 20, 2015 at 3:54 PM, Karl Schimpf <kschimpf at google.com> wrote:

> Here is another copy of the patch, including
> test/BitcodeInputs/invalid-align.bc
>
>
>
> Karl Schimpf
>
> On Fri, Feb 20, 2015 at 3:43 PM, Rafael Espíndola <
> rafael.espindola at gmail.com> wrote:
>
>> You have to attach b/test/Bitcode/Inputs/invalid-align.bc too (or use
>> git diff --binary).
>>
>> On 20 February 2015 at 18:19, Karl Schimpf <kschimpf at google.com> wrote:
>> > Oops, forgot to include final patch to be committed. Here it is.
>> >
>> >
>> > Karl Schimpf
>> >
>> > On Fri, Feb 20, 2015 at 3:08 PM, Karl Schimpf <kschimpf at google.com>
>> wrote:
>> >>
>> >> Fixed the name to BitcodeReader::parseAlignmentValue, added test
>> >> (test/Bitcode/Inputs/invalid-align.bc), and updated
>> >> test/BitcodeInputs/invalid.tests.
>> >>
>> >> jfb: Could you please commit this since I do not have commit privilege
>> >> yet. Rafael has reviewed it and has given it a LGTM.
>> >>
>> >> Karl Schimpf
>> >>
>> >> On Thu, Feb 19, 2015 at 7:09 PM, Filipe Cabecinhas <filcab at gmail.com>
>> >> wrote:
>> >>>
>> >>> Feel free to use test/Bitcode/invalid.test and add a
>> >>> test/Bitcode/Inputs/invalid-*.bc, since it's an invalid bitcode file.
>> I've
>> >>> been putting them there so they don't “pollute” test/Bitcode.
>> >>>
>> >>> Thanks,
>> >>>
>> >>>   Filipe
>> >>>
>> >>> On Thu, Feb 19, 2015 at 6:11 PM, Rafael Espíndola
>> >>> <rafael.espindola at gmail.com> wrote:
>> >>>>
>> >>>> It is OK to check in a .bc file.
>> >>>>
>> >>>> BitcodeReader::ParseAlignmentValue
>> >>>>
>> >>>> Please use the new convention (start functions with lowercase).
>> >>>>
>> >>>> LGTM with that.
>> >>>
>> >>>
>> >>
>> >
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150222/9f162af4/attachment.html>