[PATCH] Preliminary support for dynamically loadable coff objects
Lang Hames
lhames at gmail.com
Sat Feb 21 10:46:10 PST 2015
Hi Andy,
Thanks very much for working on this. It looks great.
If you plan to support more architectures in the future you should consider moving the target specific code into a subclass (along the same lines as RuntimeDyldMachO). In my experience mixing the relocation handling code for multiple architectures was a debugging and maintenance headache - I ended up expending a lot of effort to untangle that code last year.
Could you also add some tests under llvm/test/ExecutionEngine/RuntimeDyld/ ?
Cheers,
Lang.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7793
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list