[lld] r230139 - [ELF] Remove FIXME(s) that are already fixed.

Shankar Easwaran shankare at codeaurora.org
Sat Feb 21 07:51:54 PST 2015


Author: shankare
Date: Sat Feb 21 09:51:54 2015
New Revision: 230139

URL: http://llvm.org/viewvc/llvm-project?rev=230139&view=rev
Log:
[ELF] Remove FIXME(s) that are already fixed.

FIXME code was left around in few places where its already been taken care of.

This removes the FIXME's that are not needed.

Modified:
    lld/trunk/lib/ReaderWriter/ELF/Atoms.h

Modified: lld/trunk/lib/ReaderWriter/ELF/Atoms.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Atoms.h?rev=230139&r1=230138&r2=230139&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Atoms.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Atoms.h Sat Feb 21 09:51:54 2015
@@ -124,9 +124,8 @@ public:
 
   StringRef name() const override { return _name; }
 
-  // FIXME: What distinguishes a symbol in ELF that can help decide if the
-  // symbol is undefined only during build and not runtime? This will make us
-  // choose canBeNullAtBuildtime and canBeNullAtRuntime.
+  // A symbol in ELF can be undefined at build time if the symbol is a undefined
+  // weak symbol.
   CanBeNull canBeNull() const override {
     if (_symbol->getBinding() == llvm::ELF::STB_WEAK)
       return CanBeNull::canBeNullAtBuildtime;
@@ -192,7 +191,6 @@ public:
   // FIXME: Need to revisit this in future.
   Interposable interposable() const override { return interposeNo; }
 
-  // FIXME: What ways can we determine this in ELF?
   Merge merge() const override {
     if (_symbol->getBinding() == llvm::ELF::STB_WEAK)
       return mergeAsWeak;





More information about the llvm-commits mailing list