[lld] r226922 - Fix the ELF shared library build targets

Michael Spencer bigcheesegs at gmail.com
Fri Feb 20 17:46:09 PST 2015


On Fri, Feb 20, 2015 at 5:38 PM, Greg Fitzgerald <garious at gmail.com> wrote:
> On Fri, Feb 20, 2015 at 4:46 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
>> This violates the One Definition Rule.
>>
>> There's no need to try to inject a static function into these. This
>> can just be a free create##TargetName##LinkingContext(llvm::Tripple)
>> function.
>
> Hi Michael,
>
> I reverted this patch shortly after adding it.  I then implemented it
> in the way you described.
>
> -Greg

It's still implemented using a redefinition of the linking context
classes with a static function. You can't have multiple different
definitions of a class.

- Michael Spencer



More information about the llvm-commits mailing list