[PATCH] [RFC][PATCH] Minor opt to access pointers to globals via pcrel GOT entries

[Rafael Ávila de Espíndola]

Just test nits.


================
Comment at: test/MC/X86/cstexpr-gotpcrel.ll:10
@@ +9,3 @@
+; (4) Emit the GOT equivalent in case on of its uses can't be replaced by the
+;     GOT entry.
+; (5) Support for arbitrary constants into the GOTPCREL offset
----------------
Please move these comments close to each test.

================
Comment at: test/MC/X86/cstexpr-gotpcrel.ll:18
@@ +17,3 @@
+; Check that these got equivalent symbols are not emitted in the begining.
+; CHECK-NOT: _localgotequiv
+; CHECK-NOT: _extgotequiv
----------------
How about redirecting llc to %t and doing tow FileCheck runs? That way you can check in one place that they are never output.

http://reviews.llvm.org/D6922

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/