[PATCH] LowerBitSets: Introduce global layout builder.

[JF Bastien]

Nice results :-)

I honestly have a bit of a hard time visualizing how the algorithm works. Do you think you could illustrate it a bit more clearly?


================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:125
@@ +124,3 @@
+  std::vector<uint64_t> &Fragment = Fragments.back();
+  uint64_t FragmentIndex = Fragments.size()-1;
+
----------------
Format.

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:552
@@ +551,3 @@
+        [](const std::set<uint64_t> &O1, const std::set<uint64_t> &O2) {
+          return O1.size() < O2.size();
+        });
----------------
This won't be deterministic without a tie-breaker?

================
Comment at: test/Transforms/LowerBitSets/layout.ll:5
@@ +4,3 @@
+
+; CHECK: private constant { i32, i32, i32, i32, i32 } { i32 1, i32 5, i32 2, i32 4, i32 3 }
+ at a = constant i32 1
----------------
Could you add an explanation of what the test does?

http://reviews.llvm.org/D7796

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/