[PATCH] Use ".arch_extension" ARM directive to specify the additional CPU features

Sumanth Gundapaneni sgundapa at codeaurora.org
Fri Feb 20 11:35:26 PST 2015


  d) It seems that the .cpu directive for the krait cpu is orthogonal to the arch_extension part of this patch.

Almost... :)

>.arch_extension is needed to help GAS understand that krait is A9+Div, that's why it's in the same patch. **Without it, the original patch looked completely useless**. This merge was actually my fault, if you feel strongly, it should be pretty safe to split the .arch_extension from the krait changes

I agree the changes are orthogonal, but with out the use case scenario, the first patch doesn't make any sense.
I started with splitting the patches and was convinced by Tim and Renato to merge them.
If you insist, I will split them as long as other reviewers agree with it. Note that one of the patches will go with out a unit test.


http://reviews.llvm.org/D7316

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list