[PATCH] Mangler: Don't prefix MS ABI names with a leading ? character

[Rafael Espíndola]

The WIP patch is attached. Unfortunately clang still produces bogus
GVs for objc. That would have to be fixed first.

On 20 February 2015 at 13:06, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
>>> no? In particular it would miss the .L on ELF.
>>
>>
>> Yes. The lack of .L is concerning, but why have we been able to get by without the L prefix on COFF for so long with these names? Is there a bug there too? Maybe we should do the private symbol prefixing even in the presence of '?' or '\01'?
>>
>
> I think the verifier should reject globals with a \0 name that are
> internal or private. Globals with internal and private linkage can be
> renamed. It makes no sense to force a particular name. I think I have
> a wip patch for this on git. I will try to find it after lunch.
>
> The objc implementation in clang used to break this, but I think it is
> now fixed.
>
> Not adding a L prefix for a genuine private global on COFF does look like a bug.
>
> Cheers,
> Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 1088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150220/52901468/attachment.bin>