[PATCH] Remove all MMOs from memory operations when tail merging.
hfinkel at anl.gov
hfinkel at anl.gov
Fri Feb 20 10:19:39 PST 2015
================
Comment at: lib/CodeGen/BranchFolding.cpp:745
@@ +744,3 @@
+ const Value *V2 = (*I2)->getValue();
+ if (!V1 || !V2 || (V1 != V2))
+ return false;
----------------
Yes, please check all of the fields (they can have control dependencies). Also, You can just do V1 != V2, both being null is fine.
http://reviews.llvm.org/D7769
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list