[llvm] r230020 - I incorrectly marked the VORC instruction as isCommutable when I added it.
Kit Barton
kbarton at ca.ibm.com
Fri Feb 20 07:54:58 PST 2015
Author: kbarton
Date: Fri Feb 20 09:54:58 2015
New Revision: 230020
URL: http://llvm.org/viewvc/llvm-project?rev=230020&view=rev
Log:
I incorrectly marked the VORC instruction as isCommutable when I added it.
This fix removes the VORC instruction definition from the isCommutable block.
Phabricator review: http://reviews.llvm.org/D7772
Modified:
llvm/trunk/lib/Target/PowerPC/PPCInstrAltivec.td
llvm/trunk/test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll
Modified: llvm/trunk/lib/Target/PowerPC/PPCInstrAltivec.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCInstrAltivec.td?rev=230020&r1=230019&r2=230020&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCInstrAltivec.td (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCInstrAltivec.td Fri Feb 20 09:54:58 2015
@@ -986,9 +986,10 @@ def VEQV : VXForm_1<1668, (outs vrrc:$v
def VNAND : VXForm_1<1412, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB),
"vnand $vD, $vA, $vB", IIC_VecGeneral,
[(set v4i32:$vD, (vnot_ppc (and v4i32:$vA, v4i32:$vB)))]>;
+} // isCommutable
+
def VORC : VXForm_1<1348, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB),
"vorc $vD, $vA, $vB", IIC_VecGeneral,
[(set v4i32:$vD, (or v4i32:$vA,
(vnot_ppc v4i32:$vB)))]>;
-} // isCommutable
} // end HasP8Altivec
Modified: llvm/trunk/test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll?rev=230020&r1=230019&r2=230020&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll (original)
+++ llvm/trunk/test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll Fri Feb 20 09:54:58 2015
@@ -17,10 +17,13 @@ define <4 x i32> @test_vnand(<4 x i32> %
; CHECK: vnand 2, 2, 3
}
-; Test x vorc y
+; Test x vorc y and variants
define <4 x i32> @test_vorc(<4 x i32> %x, <4 x i32> %y) nounwind {
- %tmp = xor <4 x i32> %y, <i32 -1, i32 -1, i32 -1, i32 -1>
- %ret_val = or <4 x i32> %x, %tmp
- ret <4 x i32> %ret_val
-; CHECK: vorc 2, 2, 3
+ %tmp1 = xor <4 x i32> %y, <i32 -1, i32 -1, i32 -1, i32 -1>
+ %tmp2 = or <4 x i32> %x, %tmp1
+; CHECK: vorc 3, 2, 3
+ %tmp3 = xor <4 x i32> %tmp2, <i32 -1, i32 -1, i32 -1, i32 -1>
+ %tmp4 = or <4 x i32> %tmp3, %x
+; CHECK: vorc 2, 2, 3
+ ret <4 x i32> %tmp4
}
More information about the llvm-commits
mailing list