[PATCH] Link jumptable attributes consistently with unnamed_addr

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Thu Feb 19 18:15:15 PST 2015


================
Comment at: lib/Linker/LinkModules.cpp:1029
@@ -1028,1 +1028,3 @@
 
+    // Don't unset unnamed_addr on values with a jumptable attribute, since that
+    // leads to an invalid module.
----------------
Shouldn't it drop the jumptable instead? Or report an error?

If unnamed_addr is not present in a module,  then that module can depend on the address of that GV. Adding it also produces an invalid module.

http://reviews.llvm.org/D6425

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list