[PATCH] Introduce bitset metadata format and bitset lowering pass.

Kostya Serebryany kcc at google.com
Thu Feb 19 15:32:01 PST 2015


LGTM

I think at this point it will become easier to continue reviews/improvements if the code is committed. 
Let's give one more day to other reviewers -- if you don't hear significant objections please commit tomorrow.


================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:362
@@ +361,3 @@
+  DenseMap<GlobalVariable *, uint64_t> GlobalLayout;
+  for (unsigned I = 0; I != Globals.size(); ++I) {
+    GlobalLayout[Globals[I]] = CombinedGlobalLayout->getElementOffset(I);
----------------
remove {}

http://reviews.llvm.org/D7288

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list