[PATCH] Use ImmutableStatepoint during statepoint lowering.

Philip Reames listmail at philipreames.com
Thu Feb 19 14:26:46 PST 2015


LGTM w/comments addressed.  Please make sure to rebase carefully since I saw at least one cleanup patch does this today.


REPOSITORY
  rL LLVM

================
Comment at: include/llvm/IR/Statepoint.h:20
@@ -19,2 +19,3 @@
 #include "llvm/ADT/iterator_range.h"
+#include "llvm/IR/BasicBlock.h"
 #include "llvm/IR/CallSite.h"
----------------
Remove this please.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:665
@@ -663,1 +664,3 @@
+  // This function is responsible for the whole statepoint lowering process.
+  void LowerStatepoint(ImmutableStatepoint Statepoint);
 private:
----------------
Comment isn't particularly helpful. 

================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:307
@@ +306,3 @@
+  for (GCRelocateOperands relocateOpers :
+         StatepointSite.getRelocates(StatepointSite)) {
+    Relocs.push_back(relocateOpers.getUnderlyingCallSite().getInstruction());
----------------
Is this over 80 lines?  I can't tell in the diff.  If so, reformat.

http://reviews.llvm.org/D7756

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list