[llvm] r229797 - Introduce Target::createNullTargetStreamer and use it from IRObjectFile.

Peter Collingbourne peter at pcc.me.uk
Thu Feb 19 11:11:38 PST 2015


On Thu, Feb 19, 2015 at 11:01:18AM -0800, David Blaikie wrote:
> > +    MCTargetStreamer *createNullTargetStreamer(MCStreamer &S) const {
> >
> 
> Could/should this (& NullTargetStreamerCtorFn) return by unique_ptr instead?

The MCStreamer takes ownership of the target streamer on construction
(see include/llvm/MC/MCStreamer.h line 176 and lib/MC/MCStreamer.cpp line
31), so probably not at the moment. It seems reasonable to make the client
responsible for transferring ownership though.

Thanks,
-- 
Peter



More information about the llvm-commits mailing list