[PATCH] Add test suite for the Control Flow Integrity feature.

Kostya Serebryany kcc at google.com
Thu Feb 19 10:56:46 PST 2015


Looks great. 
Once Alexey LGTMs the cmake code you have my LGTM too. 
Please, whenever you get any kind of question about the CFI add a test here that answers the question. 
Of course, this patch depends on the other two.

The question about -O0 vs -O2 is more to Alexey. 
I think we do have similar cmake magic somewhere, don't we? 
It would be great to run all these tests with both -O0 and -O2


================
Comment at: test/cfi/anon-namespace.cpp:43
@@ +42,3 @@
+
+#endif
+
----------------
#endif  // TU1
here and below

================
Comment at: test/cfi/multiple-inheritance.cpp:35
@@ +34,3 @@
+  puts("1");
+  fflush(stdout);
+
----------------
If you use stderr you will not need fflush

http://reviews.llvm.org/D7738

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list