[PATCH] [compiler-rt] Allow suppression file paths be relative to the location of the executable.

Alexander Potapenko glider at google.com
Thu Feb 19 07:13:12 PST 2015


Looks good in general


================
Comment at: lib/sanitizer_common/sanitizer_common.h:221
@@ -217,1 +220,3 @@
+// Returns the path to the main executable.
+uptr ReadBinaryName(/*out*/char *buf, uptr buf_len);
 u32 GetUid();
----------------
Nit: how about "GetBinaryName"? After all, you're not reading it on Mac.

http://reviews.llvm.org/D7309

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list