[PATCH] [Sanitizers] Move the common sanitizer interface from sanitizer_internal_defs.h to a new sanitizer_interface_internal.h file

[Timur Iskhodzhanov]

Hi eugenis,

The rationale for the move is

1) sanitizer_internal_defs.h is included from asan_dll_thunk.cc, which expects only the minimal amount of declarations.
  Leaving the __sanitizer functions in sanitizer_internal_defs.h results in extra maintenance cost of asan_dll_thunk.cc (see INTERFACE_FUNCTION macro)

2) According to the top comment, sanitizer_internal_defs.h is supposed to "contain macro used in run-time libraries code."
  Clearly, the __sanitizer_* function definitions are not macros.  Also, they don't have to be declared in all our TUs.

I'm assigning you to the review as you've added the __sanitizer interface into sanitizer_internal_defs.h in http://llvm.org/viewvc/llvm-project?revision=173928&view=revision

http://reviews.llvm.org/D7758

Files:
  lib/asan/asan_interface_internal.h
  lib/sanitizer_common/CMakeLists.txt
  lib/sanitizer_common/sanitizer_common.h
  lib/sanitizer_common/sanitizer_interface_internal.h
  lib/sanitizer_common/sanitizer_internal_defs.h

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7758.20293.patch
Type: text/x-patch
Size: 7051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150219/6fff6846/attachment.bin>