[PATCH] tsan: fix PTRACE_ATTACH handling during stop-the-world

Dmitry Vyukov dvyukov at google.com
Thu Feb 19 01:04:48 PST 2015


================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc:125
@@ +124,3 @@
+        VReport(1, "Waiting on thread %d failed, detaching (errno %d).\n",
+            tid, wperrno);
+        internal_ptrace(PTRACE_DETACH, tid, NULL, NULL);
----------------
earthdok wrote:
> dvyukov wrote:
> > earthdok wrote:
> > > indent
> > it is 4 spaces aligned
> > in accordance with the Style
> nope, that's only for those cases where even the first parameter is wrapped
> otherwise you align to the first parameter
... and what if the wrapped argument does not fit onto line if you align it to the first arg?...
ok, as you wish, done
the style guide instruction that covers this seems to be "follow the style of existing code"

http://reviews.llvm.org/D7723

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list