[PATCH] Make FileCheck be a common dependency, not an ASan one.

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Wed Feb 18 19:32:19 PST 2015


Yes, r229753 makes it work without the workaround.

I'm just not sure what would be preferred:
- To have the explicit FileCheck (and not, at the very least) dependency
- Or to simply not have those dependencies and let lit error out if it
can't find them;

 Filipe

On Wed, Feb 18, 2015 at 7:24 PM, Filipe Cabecinhas <
filcab+llvm.phabricator at gmail.com> wrote:

> It might have been, thanks for pointing it out.
> I will check it and report back or re-submit as a fix to remove our
> workaround.
>
> Thanks,
>
>  Filipe
>
> On Wed, Feb 18, 2015 at 6:51 PM, Peter Collingbourne <peter at pcc.me.uk>
> wrote:
>
>> Was this fixed by r229753?
>>
>>
>> http://reviews.llvm.org/D7740
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150218/c614503d/attachment.html>


More information about the llvm-commits mailing list