[lld] r229762 - PECOFF: Fix symbol aliases

[Shankar Easwaran]

On 2/18/2015 5:11 PM, Rui Ueyama wrote:
> +  alias->setOrdinal(target->ordinal() - 1);
Wouldn't this cause a wrap around when the ordinal of the first atom is 0 ?
>   
> +// getNextOrdinal returns a monotonically increasaing uint64_t number
> +// starting from 1. There's a large gap between two numbers returned
> +// from this function, so that you can put other atoms between them.
> +uint64_t FileCOFF::getNextOrdinal() {
> +  return _ordinal++ << 32;
> +}
> +
Do you need it this to be shifted by 32 ? Wouldnt incrementing by 2 be 
enough ?

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation