[PATCH] [X86][FastIsel] Teach how to select scalar integer to float/double conversions.

Andrea Di Biagio Andrea_DiBiagio at sn.scee.net
Wed Feb 18 09:47:52 PST 2015


In http://reviews.llvm.org/D7698#125598, @qcolombet wrote:

> Hi Andrea,
>
> On a second thought, why do we need to use the AVX variant at all if we never use the first source operand?
>  The bonus point is that would kill all the code related to the implicit def.


Hi Quentin,

The main reason (at least from my point of view) is that we want to avoid mixing legacy SSE instructions and AVX instructions as much as possible. Otherwise, we end up increasing AVX-SSE transition penalties. That's why (basically everywhere in X86FastISel) we always prefer vex encoded instructions over legacy SSE instructions.

I hope this makes sense.
-Andrea


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7698

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list