[PATCH] Revert 221429 and fix bug in TargetLowering::SimplifyDemandedBits

[Gil Rapaport]

Hi Quentin,

Thanks a lot for helping with this!

One issue that still bothers me has to do with the code in X86ISelLoweing.cpp that handles the multiple uses for this optimization when Cond != TLO.Old:

- Now that SimplifyDemandedBits should not simplify multi-used values, is that code still needed?
- If it is needed, can you please explain why aren't the uses of TLO.Old being checked (for being VSELECT) and replaced? Isn't it the boolean property of TLO.Old that was damaged by the bit simplification?

Gil


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6949

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/